[wp-trac] [WordPress Trac] #10424: change get_filesystem_method()'s code for direct to reflect actual purpose

[WordPress Trac]

#10424: change get_filesystem_method()'s code for direct to reflect actual purpose
--------------------------+-------------------------------------------------
 Reporter:  dd32          |       Owner:  dd32                   
     Type:  defect (bug)  |      Status:  new                    
 Priority:  normal        |   Milestone:  3.0                    
Component:  Filesystem    |     Version:  2.9                    
 Severity:  normal        |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------
Changes (by imme-emosol):

 * cc: imme-emosol (added)


Comment:

 On ubuntu my wordpress files are owned by root:www-data
 and therefore fileowner() returns (int)0 as well, because of root user.
 Your patch did not work as I expected,
 because php seems to writes files as www-data:www-data.

 So, in an effort to recap you, I think this should :
 * check the owner of the wp-content(/plugins) folder
 * choose the option that will hopefully create new files with same
 permissions as wp-content folder

 So I added some checks to the script that do a strict group && user check
 and I changed it from __FILE__ to $context

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10424#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software