[wp-trac] [WordPress Trac] #8964: Allow adding headers to get_plugin_data

[WordPress Trac]

#8964: Allow adding headers to get_plugin_data
-------------------------+--------------------------------------------------
 Reporter:  strider72    |       Owner:  westi                        
     Type:  enhancement  |      Status:  accepted                     
 Priority:  normal       |   Milestone:  2.9                          
Component:  Plugins      |     Version:                               
 Severity:  normal       |    Keywords:  has-patch tested commit early
-------------------------+--------------------------------------------------

Comment(by strider72):

 Finding bugs, gosh stinking darn it!  (Pardon my language)

 In get_theme_data() from patch 5,

 {{{$theme_data['Name'] = $title = wp_kses( $theme_data['Name'],
 $themes_allowed_tags );}}}

 should be

 {{{$theme_data['Name'] = $theme_data['Title'] = wp_kses(
 $theme_data['Name'], $themes_allowed_tags );}}}

 Changing the subject slightly:

 Also in get_theme_data() from patch 5, at the end just before output I
 have the line:

 {{{unset( $theme_data['AuthorURI'] ); }}}

 That's there because I was rather slavishly ensuring that the output of
 the function was unchanged.  Considering that get_plugin_data() now
 returns AuthorURI, get_theme_data should do the same.  Thus, that unset()
 should be removed.

 I'll get a new patch up that addresses all of the above (plus my earlier
 comment).

 NOTE: if get_theme_data returns AuthorURI, it follows that it should also
 return Author without turning it into a link (again, making it the same as
 get_plugin_data).  That would require changes to the Themes admin page
 though, so I'll leave that for a separate ticket.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8964#comment:41>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software