[wp-trac] [WordPress Trac] #10852: improve get_page_children

WordPress Trac wp-trac at lists.automattic.com
Tue Sep 29 18:18:56 UTC 2009


#10852: improve get_page_children
--------------------------+-------------------------------------------------
 Reporter:  hailin        |       Owner:  westi    
     Type:  enhancement   |      Status:  reviewing
 Priority:  normal        |   Milestone:  2.9      
Component:  Optimization  |     Version:  2.9      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by hailin):

 mihai:
     I'm not sure calling update_page_cache in those page functions is a
 bug - it part of the cache updating mechanism.

 However, both Ryan and I have identified this as the biggest time
 consumption issue
 when there are thousands of pages.

 Can you test my patch with your 7000 pages and report back the results?
 I think Westi hold it off because he wants to see more testing results.

 You could name my implementation get_page_children2(), then use the above
 $t = microtime(true) code snippet to make a direct call of old
 get_page_children() and new get_page_children2(), then compare the time
 spent in each case.

 You could test these in index.php directly, and pass in the ID of the root
 page.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10852#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list