[wp-trac] [WordPress Trac] #10774: Include 'hidden' directories in filesystem dirlist for Direct and SSH2

[WordPress Trac]

#10774: Include 'hidden' directories in filesystem dirlist for Direct and SSH2
--------------------------+-------------------------------------------------
 Reporter:  dd32          |       Owner:  dd32       
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  2.9        
Component:  Filesystem    |     Version:  2.9        
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------
Changes (by dd32):

  * keywords:  has-patch => needs-patch


Old description:

> Ok, Seems theres a bit of a inconsistency between the return values of
> dirlist() when comparing FTP vs Direct/SSH2.
>
> Direct and SSH2(which was based on the Direct class) include a check to
> see if '.' is the first character, and dumps it in with '.' and '..'
> folders..
>
> In short, The behavior is unexpected, And i think its whats causing some
> issues with upgrading plugins which were previously svn checkouts
> (including Akismet on SVN installs).
>
> {{{.htaccess}}} files would also cause oddities like that while
> attempting to ugprade the plugin (It'd hit a Cannot remove plugin error)

New description:

 Ok, Seems theres a bit of a inconsistency between the return values of
 dirlist() when comparing FTP vs Direct/SSH2.

 Direct and SSH2(which was based on the Direct class) include a check to
 see if '.' is the first character, If it  does, And the $incdot param is
 false (as is default) it skips including the file in the return list

 In short, The behavior is unexpected, And i think its whats causing some
 issues with upgrading plugins which were previously svn checkouts
 (including Akismet on SVN installs).

 {{{.htaccess}}} files would also cause oddities like that while attempting
 to ugprade the plugin (It'd hit a Cannot remove plugin error)

--

Comment:

 Ok, I was completely wrong.

 It's entire purpose was to include hidden files.. I'm going to re-work the
 patch & whatnot to handle hidden dir's properly..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10774#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software