[wp-trac] [WordPress Trac] #7968: Use "wp_die" template message instead of plain message when Atom is disabled.

[WordPress Trac]

#7968: Use "wp_die" template message instead of plain message when Atom is
disabled.
-------------------------+--------------------------------------------------
 Reporter:  Simek        |       Owner:  westi           
     Type:  enhancement  |      Status:  accepted        
 Priority:  lowest       |   Milestone:  2.9             
Component:  AtomPub      |     Version:  2.7             
 Severity:  trivial      |    Keywords:  has-patch tested
-------------------------+--------------------------------------------------
Changes (by hakre):

  * keywords:  => has-patch tested
  * milestone:  Future Release => 2.9


Comment:

 Replying to [comment:10 westi]:
 > I discussed this with the client developers on the wp-xmlrpc list and we
 feel that it would be better to have a parsable xml response here so that
 clients can parse it out.
 Thanks for sharing your feelings but I doubt that this is in the scope of
 the ticket, so let's stick with the basics.

 > However, there doesn't appear to be any provision for this in the APP
 RFC - there is no detail spec on error responses :-(

 Well, the RFC I found (rfc5023) is perfectly clear about the issue, I
 wonder where you both might have looked:

 {{{
 5.5.  Use of HTTP Response Codes

    The Atom Protocol uses the response status codes defined in HTTP to
    indicate the success or failure of an operation.  Consult the HTTP
    specification [RFC2616] for detailed definitions of each status code.

    Implementers are asked to note that according to the HTTP
    specification, HTTP 4xx and 5xx response entities SHOULD include a
    human-readable explanation of the error.
 }}}
 http://tools.ietf.org/html/rfc5023#section-5.5

 > Moving it to future for now until we have a good workable patch in that
 direction.

 I guess you just made a mistake looking up the specs so I revert your
 changes. As stated above having a 403 with a human readable response
 (HTML) should be favored over XML. The patch looks perfectly well to me,
 it actually is the implementation of that RFC. Having an empty body in the
 response as of now is the actual bug.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/7968#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software