[wp-trac] [WordPress Trac] #10990: Include trailing ) in make_clickable if it is part of the URL

[WordPress Trac]

#10990: Include trailing ) in make_clickable if it is part of the URL
--------------------------+-------------------------------------------------
 Reporter:  josephscott   |       Owner:  azaozz   
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  2.9      
Component:  Formatting    |     Version:  2.8.4    
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by westi):

 Patch doesn't work for all the test cases we have in wordpress-tests:

 {{{
 peter-westwoods-computer:wordpress-tests peterwestwood$ php wp-test.php -t
 TestMakeClickable
 Test Suite
  TestMakeClickable
  ....F...F

 Time: 1 second

 There were 2 failures:

 1) test_strip_trailing_with_protocol_nothing_afterwards(TestMakeClickable)
 Failed asserting that two strings are equal.
 expected string <There was a spoon named (<a href="http://wordpress.org"
 rel="nofollow">http://wordpress.org</a>)>
 difference      <
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?>
 got string      <There was a spoon named (<a href="http://wordpress.org)"
 rel="nofollow">http://wordpress.org)</a>>
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-
 testcase/test_includes_formatting.php:86
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-
 testlib/base.php:526
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-test.php:107

 2) test_brackets_in_urls(TestMakeClickable)
 Failed asserting that two strings are equal.
 expected string <(<a
 href="http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software)"
 rel="nofollow">http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software)</a>)>
 difference      <
 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx?>
 got string      <(<a
 href="http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software))"
 rel="nofollow">http://en.wikipedia.org/wiki/PC_Tools_(Central_Point_Software))</a>>
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-
 testcase/test_includes_formatting.php:167
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-
 testlib/base.php:526
 /Users/peterwestwood/Documents/workspace/wordpress-tests/wp-test.php:107

 FAILURES!
 Tests: 9, Assertions: 41, Failures: 2.
 }}}

 Tests:
 http://svn.automattic.com/wordpress-tests/wp-
 testcase/test_includes_formatting.php

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10990#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software