[wp-trac] [WordPress Trac] #10788: (set|delete)_transient need some filters
WordPress Trac
wp-trac at lists.automattic.com
Mon Nov 30 09:46:11 UTC 2009
#10788: (set|delete)_transient need some filters
--------------------------+-------------------------------------------------
Reporter: dd32 | Owner: ryan
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Cache | Version: 2.9
Severity: normal | Keywords: has-patch
--------------------------+-------------------------------------------------
Changes (by nacin):
* keywords: has-patch dev-feedback => has-patch
Comment:
New patch does two things: 1) Adds additional phpdoc (@uses do_action())
and does some clean up on existing phpdoc. 2) Reverts null check back to a
false check.
Since get_option has returned false since the beginning of time if the
option doesn't exist or has no value, it doesn't make much sense to change
that now and introduce backwards compatibility issues.
Thus, this patch only adds phpdoc and standardizes hooks (by adding lots
of 'em).
Also, my escaping bug from earlier was actually invalid. get_option and
delete_option (and their _site_ counterparts) want escaped
option/transient names, while all other option and transient functions
want them unescaped. (Maybe this should be standardized with some sort of
maybe_esc_sql function.)
--
Ticket URL: <http://core.trac.wordpress.org/ticket/10788#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list