[wp-trac] [WordPress Trac] #8592: Private Pages not listed in the Parent dropdown
WordPress Trac
wp-trac at lists.automattic.com
Thu Nov 19 22:10:50 UTC 2009
#8592: Private Pages not listed in the Parent dropdown
----------------------------+-----------------------------------------------
Reporter: mtdewvirus | Owner: anonymous
Type: defect (bug) | Status: new
Priority: high | Milestone: Future Release
Component: Administration | Version: 2.9
Severity: major | Keywords: needs-patch
----------------------------+-----------------------------------------------
Comment(by mtekk):
Replying to [comment:63 Denis-de-Bernardy]:
> patch potentially introduces loads of bugs:
>
> - the check on is_admin() seems kind of weird.
> - $author_query is pointless if the author can view private pages
and/or edit others' page
> - I'm pretty sure the current parent needs to be passed to the query.
(haven't tested, but if a non-privileged author creates a page whose
parent is owned by someone else and becomes private or pending, what
happens when he edits it?)
>
1. Agree, but we need to make sure in the admin/dashboard, any user
capable of writing a page and make it a child of anyone's future, pending,
or draft page.
2. Authors can't create, publish, or edit pages. Only editors can, and
AFAIK editors can access anything private (or so says edit_private_pages
ability).
3. Ties in with my thought that the page inheritance model of WordPress
needs to be rethought. At the moment, it is not very useful in a single
site, multiple user setup.
I'm alright with this getting punted, IFF (if and only if) we get one of
the core developers to give some input on fixing the page inheritance
model.
After looking at get_pages, it looks like we may be able to place this
higher up, where it belongs, which will completely eliminate #2 (and allow
us to use read_private_pages again instead of edit_private_pages), but I
don't remember where that was.
I'm attaching what I have on my current testbed, it's different than the
code in patch 2 (uses edit_private_pages).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/8592#comment:64>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list