[wp-trac] [WordPress Trac] #10939: browser with iframes off is left a blank lightbox

[WordPress Trac]

#10939: browser with iframes off is left a blank lightbox
---------------------------+------------------------------------------------
 Reporter:  hakre          |       Owner:             
     Type:  defect (bug)   |      Status:  new        
 Priority:  normal         |   Milestone:  2.9        
Component:  Accessibility  |     Version:  2.9        
 Severity:  normal         |    Keywords:  needs-patch
---------------------------+------------------------------------------------
Changes (by nacin):

  * keywords:  => needs-patch
  * version:  2.8.4 => 2.9


Comment:

 JavaScript iframes appear in scriptaculous, thickbox, and tinymce. I agree
 those should have warnings as functionality is clearly lost.

 I do not think we need a message in {{{plugin-editor.php}}},
 {{{plugins.php}}} or {{{class-wp-upgrader.php}}}. In those instances, the
 fatal error message of a plugin is displayed in an iframe, beneath a
 warning message saying the plugin could not be activated because of an
 error. I'd call the use of iframes here progressive enhancement. You don't
 notice that there was lost functionality when iframes are disabled.

 Or, if the message is warranted, then the feedback should be something
 like "We'd show you the fatal error but you do not have iframes enabled in
 your browser."

 Also, with regards to your patch, the implementation is off.
 {{{<noframes>}}} is for framesets, not inline frames, and you can have one
 but not the other enabled in a browser. To provide alternate content for
 an iframe, you'd provide it between the iframe tags, such as
 {{{<iframe>Sorry, no iframes.</iframe>}}}.

 I'd also suggest something like this for the text:
 {{{
 This feature requires inline frames. You have iframes disabled or your
 browser does not support them.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10939#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software