[wp-trac] [WordPress Trac] #10337: Easier embeds for 2.9 (oEmbed perhaps?)
WordPress Trac
wp-trac at lists.automattic.com
Thu Nov 12 17:29:26 UTC 2009
#10337: Easier embeds for 2.9 (oEmbed perhaps?)
----------------------------+-----------------------------------------------
Reporter: ryan | Owner: Viper007Bond
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 2.9
Component: Shortcodes | Version:
Severity: normal | Keywords: needs-testing
----------------------------+-----------------------------------------------
Comment(by Otto42):
Viper007Bond: Question about the patch:
Why this?
{{{
$postmetaids = $wpdb->get_col( "SELECT meta_id FROM $wpdb->postmeta WHERE
meta_key LIKE '_oembed_%'" );
$in = implode( ',', array_fill( 1, count($postmetaids), '%d' ) );
$wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->postmeta WHERE meta_id
IN($in)", $postmetaids ) );
}}}
Why not this?
{{{
DELETE FROM $wpdb->postmeta WHERE meta_key LIKE '_oembed_%'
}}}
Only reason I can see is for the surrounding actions, which also seem
somewhat unnecessary to me. A basic action there would be enough, if the
action function needs the meta id's, it can do its own select.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/10337#comment:55>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list