[wp-trac] Re: [WordPress Trac] #8620: Fatal error with HTTP class

WordPress Trac wp-trac at lists.automattic.com
Wed May 27 14:44:38 GMT 2009


#8620: Fatal error with HTTP class
---------------------------+------------------------------------------------
 Reporter:  momo360modena  |        Owner:  westi 
     Type:  defect (bug)   |       Status:  closed
 Priority:  normal         |    Milestone:  2.8   
Component:  HTTP           |      Version:  2.7   
 Severity:  major          |   Resolution:  fixed 
 Keywords:  has-patch      |  
---------------------------+------------------------------------------------

Comment(by hakre):

 Progressivly I would say it can make sense to merge the docblocks in. I
 can take care for that.

 For Strictness I'm OK with your argumentation but therefore I would wish
 to see that everywhere in the core functions. But that is not the case.
 Good to read your words for this case.

 I can not say if object testing is faster then object casting or the other
 way round. AFAIK casting is pretty fast in PHP often faster then doing a
 conversion. So I thought not that negativly about casting. But I have not
 benchmarked it. Are you shure about your assumptions?

 My patch made the code more simple and extended the Docblock. That was
 what it was made for. I will patch the dockblock only against trunk now.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8620#comment:35>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list