[wp-trac] Re: [WordPress Trac] #9757: Allow Plugin/Theme updates
from a uploaded .zip file.
WordPress Trac
wp-trac at lists.automattic.com
Thu May 14 08:20:35 GMT 2009
#9757: Allow Plugin/Theme updates from a uploaded .zip file.
----------------------------+-----------------------------------------------
Reporter: hakre | Type: enhancement
Status: new | Priority: low
Milestone: Future Release | Component: Upgrade/Install
Version: 2.8 | Severity: normal
Keywords: needs-patch |
----------------------------+-----------------------------------------------
Comment(by DD32):
> thoughts about setting clear_destination to true in this case?
a -1 from me there.
IMO zips should be trusted less than whats already on the system, Auto-
installed Plugins have the catch that all folder names are unique, and
therefor, dont conflict, but if i download a plugin called "something Cool
by Denis" should it overwrite "Something cool by DD32" which i installed
from elsewhere?
Another option for this, Is to wp_unique_filename() (well..dirname) on the
dest. folder, That'd have the benefit of no conflicts, However, It does
have the downside that the plugin upgrader (still) doesnt respect the
plugin folders name (ie. it creates a new folder based on the zip name, or
the .org slug in the .zip rather than using the current folder (eg. core-
control installed in my-plugin-cc/ will be renamed))) - So that basically
rules that out at this stage..
Maybe for uploaded plugins a unique_name.. else if its from .org.. not..
But that doesnt feel right to me, since it varies depending on the use-
case
--
Ticket URL: <http://core.trac.wordpress.org/ticket/9757#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list