[wp-trac] Re: [WordPress Trac] #9602: eval problem in classes.php and rewrite.php

[WordPress Trac]

#9602: eval problem in classes.php and rewrite.php
--------------------------+-------------------------------------------------
 Reporter:  obsidiandh    |       Owner:  ryan     
     Type:  defect (bug)  |      Status:  new      
 Priority:  low           |   Milestone:  2.8      
Component:  Permalinks    |     Version:  2.7.1    
 Severity:  minor         |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by hakre):

 -1 for eval.

 eval is evil. really, that makes stuff hard to debug and potentially
 unsecure. and while writing the patch and thinking about the substitutions
 it came into my mind that there is a design issue within this complex that
 should be (in the future) taken care of. Therefore I would put the finger
 in there and drop the use of eval.

 the regexp callback should be really fast and the instance of the class
 has reasonable impact. have you run a speed comparison?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9602#comment:12>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software