[wp-trac] Re: [WordPress Trac] #9395: WP_Http: add support for headers split over multiple lines

[WordPress Trac]

#9395: WP_Http: add support for headers split over multiple lines
--------------------------+-------------------------------------------------
 Reporter:  wnorris       |       Owner:                  
     Type:  defect (bug)  |      Status:  new             
 Priority:  normal        |   Milestone:  2.8             
Component:  HTTP          |     Version:  2.8             
 Severity:  normal        |    Keywords:  has-patch commit
--------------------------+-------------------------------------------------

Comment(by DD32):

 Sorry, Didnt see this ticket for review.

 First code chunk: (status location changed)
  * Not sure if this is going to work correctly with proxies, I think it
 was in the loop for a reason, To catch the last status header rather than
 the first one (Which is often a proxy header)

 Second code chunk: (Multiline headers)
  * Looks good to me, Pretty sure it was just something jacob didnt feel
 like doing, no technical reason as such
  * I'd get rid of the temp var myself, and use {{{ if (
 in_array($headers[$i]{0}, array(' ', "\t")) ) {}}} instead, but thats just
 me. s/$c/$headers[$i]{0}/g is another option
  * How's the trimming going to affect headers which have whitespace? (Or
 is that against spec?
 {{{
 Header: Some Value.. Now 4 spaces:
    Now some more text
 }}}
   * It might be better to base that off a .= substr($string, 1) ?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9395#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software