[wp-trac] Re: [WordPress Trac] #9452: Plugin Editor lists all files in plugin - should limit to text only

[WordPress Trac]

#9452: Plugin Editor lists all files in plugin - should limit to text only
----------------------------+-----------------------------------------------
 Reporter:  jbsil           |        Owner:  jbsil   
     Type:  defect (bug)    |       Status:  reopened
 Priority:  normal          |    Milestone:  2.8     
Component:  Administration  |      Version:  2.8     
 Severity:  normal          |   Resolution:          
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Changes (by hakre):

  * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 @denis: 100%/.error/top: well, not with that editor page.

 @bingorabbit: denis assumed that 100% is ok here. but it is not this time
 because of the wrong placed error message.

 I still think what wp_die() is best here. the error message now pops
 mostyl because of better file sanitization and the new check for editable
 textfiles. because the action is invalid, wp_die() is perfectly fitting
 here.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9452#comment:23>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software