[wp-trac] Re: [WordPress Trac] #9635: Comments Query Needs Filters

[WordPress Trac]

#9635: Comments Query Needs Filters
--------------------------+-------------------------------------------------
 Reporter:  filosofo      |       Owner:                          
     Type:  defect (bug)  |      Status:  new                     
 Priority:  normal        |   Milestone:  2.8                     
Component:  Comments      |     Version:  2.8                     
 Severity:  normal        |    Keywords:  comments-query has-patch
--------------------------+-------------------------------------------------

Comment(by filosofo):

 Replying to [comment:4 Denis-de-Bernardy]:
 > dunno I haven't actually tested the patch. but while scanning the
 patched file, I ended up wondering if the group by statement may end up
 containing junk that would mess the query up. testing would reveal if it
 does.

 I updated the patch to pass a blank string to the filter.

 Replying to [comment:4 Denis-de-Bernardy]:
 > it might not be very useful on the singular query, too.

 Well, I can think of a couple of situations in which I could use a GROUP
 BY querying comments on a singular object, but that doesn't really matter
 for the purposes of this ticket.  What matters is that this filter already
 exists for the other, non-singular comments query, so for consistency's
 sake it should be available with the singular one.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9635#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software