[wp-trac] Re: [WordPress Trac] #9633: wp:meta_value does not escape correctly

WordPress Trac wp-trac at lists.automattic.com
Mon May 4 13:41:56 GMT 2009


#9633: wp:meta_value does not escape correctly
--------------------------+-------------------------------------------------
 Reporter:  gslin         |        Owner:         
     Type:  defect (bug)  |       Status:  closed 
 Priority:  normal        |    Milestone:  2.8    
Component:  Export        |      Version:         
 Severity:  normal        |   Resolution:  wontfix
 Keywords:  needs-patch   |  
--------------------------+-------------------------------------------------
Changes (by hakre):

  * status:  new => closed
  * resolution:  => wontfix


Comment:

 generally ''html_specialchars()'' should be sufficent because the export
 names the charset used and therefore ''html_enteties()'' is not needed.

 but this is quite theoretical, most important is the import. there is not
 a problem with that invalid xml export, wordpress does not take care for
 validity on the import side nor does it have a problem with & characters
 inside the content:

 {{{
 // Now for post meta
 preg_match_all('|<wp:postmeta>(.*?)</wp:postmeta>|is', $post, $postmeta);
 }}}
 ''/wordpress-trunk/wp-admin/import/wordpress.php ~ line 533''

 so there is no bug with the export. additionally, the import does not
 decode anything. therefore, the content should not be encoded on export,
 wether be it with html_specialchar() nor with html_entities(). this would
 break the import.

 i suggest to close as won't fix now. the other suggestion is to improve
 the import as well but that needs a bigger patch and more developer
 feedback. without adoption in the immport a fix here should not considered
 to be usefull because it will break the import.

 gerenally i think this should be fixed in import and export. feel free to
 reopen and provide more information.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9633#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list