[wp-trac] Re: [WordPress Trac] #9697: Update PHP mailer to lates version [ 2.0.4 ]

WordPress Trac wp-trac at lists.automattic.com
Sat May 2 15:07:34 GMT 2009


#9697: Update PHP mailer to lates version [ 2.0.4 ]
-------------------------+--------------------------------------------------
 Reporter:  Simek        |       Owner:                        
     Type:  enhancement  |      Status:  new                   
 Priority:  normal       |   Milestone:  2.8                   
Component:  Mail         |     Version:  2.7.1                 
 Severity:  normal       |    Keywords:  has-patch dev-feedback
-------------------------+--------------------------------------------------

Comment(by hakre):

 Here is something I can not confirm that the change has been made correct.
 Change from:
 {{{    /* There should not be any EOL in the string */
     $encoded = preg_replace("/[\r\n]/", '', $str);}}}
 To:
 {{{        /* There should not be any EOL in the string */
 $encoded = preg_replace("[\r\n]", '', $str);}}}
 The later one will only remove the strings "\r\n" and not any combination
 of "\r" and "\n". The code is related to quoted printable ( function
 EncodeQ() ). I'm not well with quoted printable and do not understand
 fully the term EOL here.

 But what I can say is, that it is not explicitly named in the changelog
 and therefore I assume that this might be an accident. Another Sign of
 that being an accident is the case, that it is not a valid pcre pattern.
 the starting and ending delimiter have been left out. as far as i know
 this is not possible.

 I will try to pose the question with the phpmailer project. Until that I
 suggested to patch this place it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9697#comment:8>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list