[wp-trac] Re: [WordPress Trac] #6593: Tags with custom slugs get recreated on post edit screen

[WordPress Trac]

#6593: Tags with custom slugs get recreated on post edit screen
-------------------------------------------------+--------------------------
 Reporter:  jhodgdon                             |        Owner:  ryan
     Type:  defect (bug)                         |       Status:  new 
 Priority:  normal                               |    Milestone:  2.8 
Component:  Taxonomy                             |      Version:  2.5 
 Severity:  major                                |   Resolution:      
 Keywords:  tag custom slug duplicity has-patch  |  
-------------------------------------------------+--------------------------
Changes (by jhodgdon):

  * keywords:  tag custom slug duplicity needs-patch => tag custom slug
               duplicity has-patch
  * owner:  jhodgdon => ryan
  * status:  assigned => new


Comment:

 The patch I just added fixes the apostrophes issue. The problem turned out
 to be fairly straightforward -- when WP receives POST data on post save,
 it has all the backslashes and quotes escaped. So we have to strip them
 back out. The rest of the post save routine does this, but the tag stuff
 wasn't.

 So it was trying to compare "Man\'s Relationship" to the saved tag "Man's
 Relationship", and of course it was failing and creating a new tag
 instead.

 I also fixed a second problem in this patch, which was that the Tag Cloud
 option for selecting tags wasn't working -- it was sanitizing the tag
 cloud for display (i.e. applying display filters), and then assuming the
 raw unfiltered name was OK to insert into the tags list. The solution
 (which is ugly but correct) is to display a tag cloud with unfiltered
 names, so that when you click on one the correct unfiltered term name is
 added to the post.

 I haven't looked at #9397 yet. So far I think this is probably only a fix
 for #6593.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/6593#comment:50>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software