[wp-trac] Re: [WordPress Trac] #9672: Better filtering for image_downsize()

WordPress Trac wp-trac at lists.automattic.com
Fri May 1 13:56:39 GMT 2009


#9672: Better filtering for image_downsize()
-------------------------+--------------------------------------------------
 Reporter:  scribu       |       Owner:                       
     Type:  enhancement  |      Status:  new                  
 Priority:  normal       |   Milestone:  2.8                  
Component:  Media        |     Version:  2.7.1                
 Severity:  normal       |    Keywords:  has-patch 2nd-opinion
-------------------------+--------------------------------------------------

Comment(by scribu):

 Replying to [comment:2 Denis-de-Bernardy]:
 > the current patch changes the semantics of the existing patch. if a
 plugin relies on it and checks for !== false before doing its stuff, that
 plugin will break. so we might want to use add a different hook instead.
 >

 If the plugin relies on !== false, it means that it will also conflict
 with another plugin that uses the hook.

 So it's not a very good plugin, not because of it's author, but because of
 the suboptimal way this filter has been applied. Hence the need for this
 patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9672#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list