[wp-trac] Re: [WordPress Trac] #4011: add global proxy support in options

[WordPress Trac]

#4011: add global proxy support in options
----------------------------+-----------------------------------------------
 Reporter:  tmountjr        |       Owner:  jacobsantos                         
     Type:  task (blessed)  |      Status:  new                                 
 Priority:  normal          |   Milestone:  2.8                                 
Component:  HTTP            |     Version:  2.2                                 
 Severity:  normal          |    Keywords:  proxy has-patch commit needs-testing
----------------------------+-----------------------------------------------

Comment(by DD32):

 > line 121 and 169: if has_filter() condition then do_action() call.
 > Shouldn't that be either has_action() and do_action() or has_filter()
 and apply_filter() ?

 Action, Filter, Same thing to WordPress. The difference is that when you
 call filters, it passes the value around, When you call action, it doesnt
 bother.

 > lines 549 and 1498, for example is_array( WP_ACCESSABLE_HOSTS ).
 You are indeed correct, Thats why people should test the damn patches
 before submitting them!

 I'm thinking a Comma seperated list would be better: {{{define(..,
 'localhost, api.wordpress.org, etc.someplace'); }}}

 >  get_bloginfo('site_url') > 'site_url' is not a valid parameter
 *Sigh* I'll get that fixed too.

 > line 539: if ( $uri == $home['host'] )
 Hm, Looking at the code, and the fact it checks specifically for
 'localhost' I think its supposed to only pick up requests straight to
 localhost.. But you're right, It would be better based on parsing request.

 I'll get a new patch based off this (and any other comments in the next
 12~48hrs)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/4011#comment:31>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software