[wp-trac] Re: [WordPress Trac] #9388: safety guard for publish_future_post

WordPress Trac wp-trac at lists.automattic.com
Tue Mar 24 19:14:35 GMT 2009


#9388: safety guard for publish_future_post
--------------------------+-------------------------------------------------
 Reporter:  hailin        |       Owner:  anonymous 
     Type:  defect (bug)  |      Status:  new       
 Priority:  normal        |   Milestone:  Unassigned
Component:  General       |     Version:            
 Severity:  normal        |    Keywords:            
--------------------------+-------------------------------------------------

Comment(by hailin):

 Some users reported that it appears to only happen if he edit the sheduled
 post after sheduling it. That points to the potential issue in
 _transition_post_status in which we ALWAYS deletes the existing cron
 entry.

 9388_schedule.diff avoid deleting publish_future_post hook when
 transitioning post.
 This certainly will leave some stale entries in cron options table, but
 that is fine. In check_and_publish_future_post($post_id), we do nothing
 when the status is not 'future'

 if ( 'future' != $post->post_status )
         return;

 So I believe it is better to leave a few stale entries in the table, then
 mistakenly delete a valid one (and never add it back due to other
 circumstances).  Users are pretty stressful and (angry) when their
 scheduled posts failed to show up and they have to manually intervene.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9388#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list