[wp-trac] Re: [WordPress Trac] #9273: Add RSS Error handling functionality to RSS Widget displays

[WordPress Trac]

#9273: Add RSS Error handling functionality to RSS Widget displays
--------------------------+-------------------------------------------------
 Reporter:  DD32          |        Owner:  anonymous
     Type:  defect (bug)  |       Status:  reopened 
 Priority:  normal        |    Milestone:  2.8      
Component:  General       |      Version:  2.8      
 Severity:  normal        |   Resolution:           
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------
Changes (by DD32):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 trunk/wp-includes/widgets.php
 {{{
 1540    1540    function wp_widget_rss_output( $rss, $args = array() ) {
 1541    1541        if ( is_string( $rss ) ) {
 1542    1542            if ( !$rss = fetch_feed($rss) )
 1543    1543                return;
 1544    1544        } elseif ( is_array($rss) && isset($rss['url']) ) {
 1545    1545            $args = $rss;
 1546    1546            if ( !$rss = fetch_feed($rss['url']) )
 1547    1547                return;
 1548    1548        } elseif ( !is_object($rss) ) {
         1549            return;
         1550        }
 }}}

 needs to be cleaned up a bit more, Mainly refactoring the !$rss cases,
 Might need to check the rest of core for similar uses of fetch_feed().

 I'll take a look later.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9273#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software