[wp-trac] Re: [WordPress Trac] #10170: File Permissions on Creation (Plugin but might be Theme as well)

[WordPress Trac]

#10170: File Permissions on Creation (Plugin but might be Theme as well)
-------------------------------------+--------------------------------------
 Reporter:  hakre                    |        Owner:  dd32    
     Type:  defect (bug)             |       Status:  reopened
 Priority:  normal                   |    Milestone:  2.8.1   
Component:  Filesystem               |      Version:  2.8     
 Severity:  normal                   |   Resolution:          
 Keywords:  has-patch tested commit  |  
-------------------------------------+--------------------------------------

Comment(by dd32):

 > function mkdir(): if( ! $chmod ) with default of $chmod = false is
 unable for a $chmod = 0000; (int 0 as octal representation). that is a
 valid permission in unix, right? so better to comapre against NULL again
 (=== null)

 True. Can do a  false === then.. But seriously, Who'd be setting it to
 0000 in their right mind? :) I realise its valid and all, But theres
 little need for it to be set to that, let alone by wordpress.

 > TYPO: return false; //Prevent tihs function looping again. in line 213.
 Argh. I wish my editor had a spell checking function for comments..
 Would've stoped me making that typo.. oh.. how many months ago?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10170#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software