[wp-trac] Re: [WordPress Trac] #10170: File Permissions on Creation (Plugin but might be Theme as well)

WordPress Trac wp-trac at lists.automattic.com
Sun Jun 28 01:22:09 GMT 2009


#10170: File Permissions on Creation (Plugin but might be Theme as well)
-------------------------------------+--------------------------------------
 Reporter:  hakre                    |        Owner:  dd32    
     Type:  defect (bug)             |       Status:  reopened
 Priority:  normal                   |    Milestone:  2.8.1   
Component:  Filesystem               |      Version:  2.8     
 Severity:  normal                   |   Resolution:          
 Keywords:  has-patch tested commit  |  
-------------------------------------+--------------------------------------

Comment(by dd32):

 > Looks like the patch may cause problems in some cases as the function
 uses $this->permission which is set to umask() by default and is usually
 22 (0022). This actually doesn't seem right.

 $this->permission should really be set to 0777 & !umask() i think..

 Should just strip the permission var out of the class, we're relying upon
 FS_CHMOD_(FILE|DIR) now anyway..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10170#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list