[wp-trac] Re: [WordPress Trac] #10231: missing hook in WP_HTTP

WordPress Trac wp-trac at lists.automattic.com
Sat Jun 27 01:28:41 GMT 2009

#10231: missing hook in WP_HTTP
 Reporter:  Denis-de-Bernardy        |        Owner:  dd32    
     Type:  defect (bug)             |       Status:  reopened
 Priority:  normal                   |    Milestone:  2.8.1   
Component:  HTTP                     |      Version:  2.8     
 Severity:  normal                   |   Resolution:          
 Keywords:  has-patch tested commit  |  

Comment(by Denis-de-Bernardy):

 Some IRC logs:

 Dude, HTTP has such a large overhead already.
 3:23 AM
 Which is partly way I didn't do it in the first place.
 3:24 AM
 Well, given the ratio of plugin API verses HTTP request, there really
 isn't a comparsion.
 3:24 AM
 Be like 1:10000000000 or something.
 3:24 AM
 Well, localization does have a higher overhead than the Plugin API.
 3:25 AM ddebernardy
 3:25 AM
 and this hook actually improves the overhead
 3:25 AM
 since a plugin can then prevent the HTTP request before it's even
 3:26 AM
 I mean, heck, consider it for a moment
 3:26 AM
 http request to a protected zip file
 3:26 AM
 which redirects, using a 302, to a login form
 3:26 AM
 WP diligently downloads the form, and tries to unzip it
 3:26 AM
 sure I could manage this on my server
 3:26 AM
 and check the user agent
 3:26 AM
 but it's ridiculous
 3:27 AM
 one hook in there, and users get the correct error, i.e. "time to renew
 your membership"
 3:27 AM
 without a request in the first place
 3:27 AM
 whereas, without it, they get an error (bad zip)
 3:27 AM
 and I get a support request

Ticket URL: <http://core.trac.wordpress.org/ticket/10231#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list