[wp-trac] Re: [WordPress Trac] #5120: _wp_unfiltered_html_comment breaks XHTML validity

WordPress Trac wp-trac at lists.automattic.com
Wed Jun 17 17:07:35 GMT 2009


#5120: _wp_unfiltered_html_comment breaks XHTML validity
--------------------------+-------------------------------------------------
 Reporter:  jrawle        |        Owner:  anonymous
     Type:  defect (bug)  |       Status:  reopened 
 Priority:  normal        |    Milestone:           
Component:  Template      |      Version:  2.8      
 Severity:  normal        |   Resolution:           
 Keywords:                |  
--------------------------+-------------------------------------------------

Comment(by Elpie):

 I'm sorry, but I fail to see why this was closed again. This bug still
 exists, its not a new bug, and its easy enough to fix.

 There are two issues here - theme developers not placing the do_action
 inside a block level element. This should be documented in the Codex for
 reference and the default themes updated.

 The second issue is that the core uses XML ID syntax in three files (apart
 from the themes): comment-template.php, admin-ajax.php and wp-comments-
 post.php.

 _wp_unfiltered_html_comment needs to be changed to an ID that starts with
 a letter. Would renaming this to wp_unfiltered_html_comment cause any
 issues?

 Fixing both these will allow frontend themes to render as valid XHTML.

 I will add the diffs for the default themes shortly. Once I have tested
 the ID changes I will add patches for those too.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/5120#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list