[wp-trac] Re: [WordPress Trac] #10192: Installer/Upgrader bugs and tweaks

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 16 19:15:24 GMT 2009


#10192: Installer/Upgrader bugs and tweaks
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  Denis-de-Bernardy     
     Type:  defect (bug)       |      Status:  new                   
 Priority:  normal             |   Milestone:  2.8.1                 
Component:  Upgrade/Install    |     Version:  2.8                   
 Severity:  normal             |    Keywords:  has-patch needs-review
-------------------------------+--------------------------------------------
Changes (by Denis-de-Bernardy):

  * keywords:  => has-patch needs-review


Comment:

 first batch attached, for plugins.

 tested except for this part, which seemed very wrong:

 {{{
 -       $update_plugins = get_option('update_plugins');
 +       $update_plugins = get_transient('update_plugins');

 ...

 -       delete_option('update_plugins');
 +       delete_transient('update_plugins');
 }}}

 a few comments on the patch:

  - changes to wp-includes/update.php merely make the code conform with the
 comments
  - the addition of the $res->external allows to remove the link to "Plugin
 page on WordPress.org" thingy, which is irrelevant when the plugin is
 hosted elsewhere
  - $api->rating was missing a conditional statement

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10192#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list