[wp-trac] Re: [WordPress Trac] #10181: Warnings after post/page save

[WordPress Trac]

#10181: Warnings after post/page save
--------------------------+-------------------------------------------------
 Reporter:  Viper007Bond  |        Type:  defect (bug)
   Status:  new           |    Priority:  normal      
Milestone:  2.8.1         |   Component:  Autosave    
  Version:  2.8           |    Severity:  blocker     
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------

Comment(by Denis-de-Bernardy):

 posting the IRC logs for reference:


 {{{

 1:31 AM ddebernardy
 I think there are two issues
 1:31 AM Viper007Bond
 there are
 1:31 AM ddebernardy
 one is we don't check that it's writable
 1:31 AM Viper007Bond
 (it is)
 1:31 AM ddebernardy
 the is_writable check is different for IIS and apache, but we can manage
 that
 1:31 AM Viper007Bond
 i'm on apache
 1:31 AM
 the file is 777
 1:31 AM ddebernardy
 the other is that we're trying to do this a dozen times, and that
 definitely isn't normal
 1:32 AM Viper007Bond
 one write per line or something
 1:32 AM
 foreach ( $markerdata as $n => $markerline ) {
 1:32 AM
 oh, wait, maybe not
 1:32 AM
 hmm
 1:33 AM ddebernardy
 nah, I'd think it's related to do_action(save_post) et al being called
 multiple times (once per post, and once per autosave, and once per
 revision, etc, and possibly more than once each
 1:33 AM Viper007Bond
 save_mod_rewrite_rules() is getting called too often
 1:34 AM
 infact it doesn't even need to be called at all when you save a post
 1:34 AM
 not since like 2.0.x
 1:34 AM ddebernardy
 it used to, when the rules were all in the htaccess file
 1:34 AM Viper007Bond
 yep
 1:34 AM ddebernardy
 but indeed, now they don't, we merely need to update the option thingy
 1:35 AM
 even then, though, we need to make sure it only ever gets called once when
 needed
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10181#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software