[wp-trac] Re: [WordPress Trac] #10147: Improve SimplePie memory usage

[WordPress Trac]

#10147: Improve SimplePie memory usage
-------------------------+--------------------------------------------------
 Reporter:  link92       |       Owner:  Denis-de-Bernardy     
     Type:  enhancement  |      Status:  new                   
 Priority:  normal       |   Milestone:  2.9                   
Component:  Performance  |     Version:  2.8                   
 Severity:  normal       |    Keywords:  has-patch needs-review
-------------------------+--------------------------------------------------

Comment(by link92):

 Replying to [comment:6 Denis-de-Bernardy]:
 > Thanks. Out of curiosity, do you know why they're not using php's built-
 in parse_url() function?
 >
 >
 http://bugs.simplepie.org/repositories/diff/sp1/trunk/simplepie.inc?rev=1036

 We don't, because, uh… um, I wrote that code years ago? I think the answer
 is something along the lines of a few things in the manual:

  * "Invalid characters are replaced by _." (This goes against what is
 needed for web compat.)
  * "On seriously malformed URLs, parse_url() may return FALSE and emit a
 E_WARNING." (We want to break up everything before we try and make it
 valid, again for web compat.)
  * "This function doesn't work with relative URLs." (Yeah, we parse those
 a lot, turning relative URIs into absolute ones.)

 If the manual is wrong on all three things I'll remove our own parse_url.
 :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10147#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software