[wp-trac] Re: [WordPress Trac] #4967: RSS feed is never full

[WordPress Trac]

#4967: RSS feed is never full
--------------------------+-------------------------------------------------
 Reporter:  markjaquith   |        Owner:  anonymous
     Type:  defect (bug)  |       Status:  reopened 
 Priority:  normal        |    Milestone:  2.9      
Component:  Feeds         |      Version:  2.8      
 Severity:  normal        |   Resolution:           
 Keywords:  needs-patch   |  
--------------------------+-------------------------------------------------

Comment(by Denis-de-Bernardy):

 Replying to [comment:21 peaceablewhale]:
 > get_query_object_id is used in #9510 as well. It's useful for getting
 the id of the query.

 I still think it's not needed. better use
 wp_the_query->get_queried_object_id() imo.

 > The str_replace is necessary because the URLs returned by the
 get_xxx_feed_link functions are HTML/XML encoded, the str_replace is used
 for converting "&" back to "&". It seems that esc_url does not do do,
 please let me know if it does and I will correct the patch.

 what might be needed is an extra param for these functions instead, then,
 e.g. escape = true or context = display, and use esc_url()/esc_url_raw()
 depending on the context.

 > Again, I am afraid that I cannot join the IRC chat due to timezone
 difference :(

 ok, I'll bring it up for you.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/4967#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software