[wp-trac] Re: [WordPress Trac] #10067: theme_basename() not using get_theme_root()

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 8 10:26:05 GMT 2009

#10067: theme_basename() not using get_theme_root()
 Reporter:  bforchhammer  |       Owner:                       
     Type:  defect (bug)  |      Status:  new                  
 Priority:  normal        |   Milestone:  2.9                  
Component:  Themes        |     Version:  2.8                  
 Severity:  normal        |    Keywords:  has-patch 2nd-opinion

Comment(by bforchhammer):

 Replying to [comment:5 dd32]:
 > I'd agree with you, Except for the fact it was done differently for a
 ... which would be? :-)

 So if the function is called with the filepath to a themes'
 `functions.php` you'd get `"functions.php"` as a result instead of
 `"mythemename/functions.php"`. If we'd use it as suggested in #10011 then
 the result of the function would be used as an action key; I think the
 keyname including `mythemename` would be better in that case because it's
 more ''unique''.

 Of course perhaps it's the use of the function that would need to be
 different, but as far as I can see `theme_basename()` is also not actually
 being used anywhere else at the moment...

Ticket URL: <http://core.trac.wordpress.org/ticket/10067#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list