[wp-trac] Re: [WordPress Trac] #10067: theme_basename() not using get_theme_root()

[WordPress Trac]

#10067: theme_basename() not using get_theme_root()
--------------------------+-------------------------------------------------
 Reporter:  bforchhammer  |       Owner:                       
     Type:  defect (bug)  |      Status:  new                  
 Priority:  normal        |   Milestone:  Unassigned           
Component:  Themes        |     Version:  2.8                  
 Severity:  normal        |    Keywords:  has-patch 2nd-opinion
--------------------------+-------------------------------------------------

Comment(by bforchhammer):

 Replying to [comment:2 filosofo]:
 > The regexp in the patch does not match the subdirectory of the
 {{{themes/}}} directory, as does the original line.  I think it should be:
 >
 > {{{
 > $file = preg_replace('#^'. preg_quote($theme_dir, '#')
 .'/.*?/#','',$file); // get relative path from theme dir
 > }}}
 Shouldn't the file name include the name of the theme folder? At least
 that's how `plugin_basename()` works; it includes the folder name of the
 plugin.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10067#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software