[wp-trac] Re: [WordPress Trac] #9935: Quick editor for comments converts encoded HTML entities back into plain form

[WordPress Trac]

#9935: Quick editor for comments converts encoded HTML entities back into plain
form
---------------------------+------------------------------------------------
  Reporter:  michaeltyson  |        Type:  defect (bug)                                                                     
    Status:  reopened      |    Priority:  normal                                                                           
 Milestone:  2.9           |   Component:  Comments                                                                         
   Version:  2.7.1         |    Severity:  minor                                                                            
Resolution:                |    Keywords:  has-patch needs-testing comments quick edit html entities encode htmlspecialchars
---------------------------+------------------------------------------------
Changes (by azaozz):

  * milestone:  2.8 => 2.9


Comment:

 Adding `htmlspecialchars($comment->comment_content, ENT_QUOTES);` for the
 hidden textarea holding the content for Quick Edit seems to properly
 double-encode entities but as Ryan said, perhaps better to leave for early
 2.9 as it might break something else (not enough time to test it
 properly).

 `comment_text()/get_comment_text()` will need fixing. Looks like they will
 need improved context filtering as the comment text is used in several
 different contexts: display, feeds, email...

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9935#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software