[wp-trac] Re: [WordPress Trac] #10013: poorly documented widget args are confusing

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 2 20:30:16 GMT 2009


#10013: poorly documented widget args are confusing
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  azaozz      
     Type:  defect (bug)       |      Status:  new         
 Priority:  high               |   Milestone:  2.8         
Component:  Widgets            |     Version:              
 Severity:  blocker            |    Keywords:  dev-feedback
-------------------------------+--------------------------------------------

Comment(by Denis-de-Bernardy):

 widget_update_callback hook has inconsistent args.

 {{{
 $instance = apply_filters('widget_update_callback', $instance,
 $new_instance, $this);
 }}}

 should be something like:

 {{{
 $instance = apply_filters('widget_update_callback', $instance,
 $new_instance, $old_instance, $this);
 }}}

 else you don't have the same args as in the update() method for WP_Widgets

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10013#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list