[wp-trac] [WordPress Trac] #9510: Multiple feed fixes and enhancements

[WordPress Trac]

#9510: Multiple feed fixes and enhancements
----------------------------+-----------------------------------------------
 Reporter:  peaceablewhale  |       Owner:                        
     Type:  enhancement     |      Status:  new                   
 Priority:  high            |   Milestone:  2.9                   
Component:  Feeds           |     Version:  2.7.1                 
 Severity:  major           |    Keywords:  has-patch needs-review
----------------------------+-----------------------------------------------
Changes (by beaulebens):

 * cc: beau@… (added)


Comment:

 Not to be too picky, but it'd be nice if this was closer to the
 [http://codex.wordpress.org/WordPress_Coding_Standards WordPress Coding
 Standard]. Specifically, reversing most comparisons, spacing things out a
 bit to make them easier to read and avoiding quote-escaping by going
 between single and double quotes where appropriate.

 That being said, after a very quick visual skim over the code it looks
 like it adds a lot more flexibility and robustness to the feed system of
 WP, so I'm all for it (haven't tested to see if the patch applies cleanly
 or does as advertised). Looks very thorough.

 feed_link() and feed_entry_link() looked identical (except for the filter
 they run), perhaps they can just be combined into a more generic
 feed_link() function, with a parameter indicating what filter to run over
 the resulting code, or just have it run at the point that calls them?

 You're using get_lastpostmodified() to get a value for feed_updated(), but
 it seems like that value would not necessarily be accurate for anything
 except the full-site feed. If there's an easy way to get that date from
 the first matching item in the feed, that seems like that would
 consistently give you the correct value for that specific feed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9510#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software