[wp-trac] [WordPress Trac] #10424: change get_filesystem_method()'s code for direct to reflect actual purpose

[WordPress Trac]

#10424: change get_filesystem_method()'s code for direct to reflect actual purpose
--------------------------+-------------------------------------------------
 Reporter:  dd32          |       Owner:  dd32       
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  2.9        
Component:  Filesystem    |     Version:  2.9        
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------
 due to tickets such as #10205 and #10423 I propose we add some
 documentation, or change the code a bit to reflect to others the intended
 purpose of the code.

 Eg, something such as this could potentially work:
 {{{
 if ( file_owner($temp_file) !== false && file_owner(__FILE__) ===
 file_owner($temp_file) ) {
 //use direct
 }
 }}}

 Too many people assume its a typo, and just a complex is_writable() call..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10424>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software