[wp-trac] [WordPress Trac] #9235: Extract real IP behind a load balancer
WordPress Trac
wp-trac at lists.automattic.com
Mon Jul 13 11:54:29 UTC 2009
#9235: Extract real IP behind a load balancer
-------------------------------+--------------------------------------------
Reporter: Denis-de-Bernardy | Owner:
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.9
Component: Optimization | Version: 2.7
Severity: normal | Keywords: has-patch tested commit early
-------------------------------+--------------------------------------------
Comment(by dd32):
+1 for including a check in core.. -1 for just having a comment.
This doesn't only affect load balances, It also affects extracting the
correct IP when the web browser is behind a proxy.
Look at what other software which relies on IP addresses a bit more has
done, for example, docuwiki:
http://dev.splitbrain.org/reference/dokuwiki/inc/common.php.source.html#l591
Sure, Its a bit complex for what we need.. but it shows that if IP's are
to be stored/mentioned (ie. comments), WordPress might as well get it
right.
It can even be in a function such as that and only called when needed (ie.
comment being added) to reduce server overheads, most page loads dont need
the "real ip"
--
Ticket URL: <http://core.trac.wordpress.org/ticket/9235#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list