[wp-trac] Re: [WordPress Trac] #8568: Plugin activation hook should not be run when scraping errors.

WordPress Trac wp-trac at lists.automattic.com
Sat Jan 31 08:12:54 GMT 2009


#8568: Plugin activation hook should not be run when scraping errors.
------------------------------------------------------+---------------------
 Reporter:  sambauers                                 |        Owner:  anonymous
     Type:  defect (bug)                              |       Status:  new      
 Priority:  normal                                    |    Milestone:  2.7.1    
Component:  Administration                            |      Version:  2.7      
 Severity:  normal                                    |   Resolution:           
 Keywords:  has-patch dev-feedback reporter-feedback  |  
------------------------------------------------------+---------------------
Comment (by DD32):

 > The Request in Question is 'error_scrape'. I can not find a clear
 description what this means and for what the code is intended for.

 It if for after a failed activation, To display the errors produced to the
 web browser.

 > Anyway, I adopt the criticism in this patch partly: It is simply unclear
 what should happen here. Is the Plugin Activated anyway afterwards or is
 this a Test _only_?

 It is a re-creation of a activation failure, with the intent to display
 the error to the browser.

 > What about creating an additional Testdrive Process that is run only on
 Activation?

 This happens, If upon activation, A error occurs, Then the plugin will not
 be activated, Instead, It'll direct back to the plugins page, an an iframe
 with error_scrape will load up.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8568#comment:8>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list