[wp-trac] Re: [WordPress Trac] #8887: Ticket #6788 broke postmaster attachment handling

[WordPress Trac]

#8887: Ticket #6788 broke postmaster attachment handling
-------------------------------+--------------------------------------------
 Reporter:  wwoley             |        Owner:  westi   
     Type:  defect (bug)       |       Status:  assigned
 Priority:  normal             |    Milestone:  2.7.1   
Component:  Mail               |      Version:  2.7     
 Severity:  normal             |   Resolution:          
 Keywords:  reporter-feedback  |  
-------------------------------+--------------------------------------------
Comment (by wwoley):

 I think the placement there will work, but I think we should probably un-
 break any plugins that were broken by the insertion of the

 if ( function_exists('iconv') && ! empty( $charset ) ) {
                 $content = iconv($charset, get_option('blog_charset'),
 $content);
         }

 line first by moving the original-named filter back near the original
 location.  (I know the additional filter was my idea) That would probably
 be the best action for now and would allow broken plugins to start working
 again with the patch.  So maybe you can just move the

 $post_content = apply_filters('phone_content', $content);

 line to that same location, keeping the the comments so future developers
 know why it's located there and not somewhere else.

 Previously, the filter line was after the

 if (...)
 {
 quoted_printable_decode($content);
 }

 call, but placing it before probably makes more sense.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8887#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software