[wp-trac] [WordPress Trac] #11172: Login form template function
WordPress Trac
wp-trac at lists.automattic.com
Tue Dec 29 17:39:03 UTC 2009
#11172: Login form template function
----------------------------+-----------------------------------------------
Reporter: ryan | Owner: beaulebens
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.0
Component: Template | Version: 2.8.5
Severity: normal | Keywords: has-patch
----------------------------+-----------------------------------------------
Comment(by beaulebens):
Thanks for your feedback everyone. I've attached a new patch
(11172.003.diff) which does the following:
* Moves everything to an args array, which is filtered, and overrideable
when the function is called. Makes most ids, labels etc filterable in one
place.
* Added in the 3 actions (top/middle/bottom) suggested by aaroncampbell
* Removed the vulnerability when using HTTP_HOST, don't know if
REQUEST_URI could still be an issue as it's passed through site_url()?
* Removed the logged in test, so developers should do that themselves
outside the function
* Added some classes to the P tags to help isolate individual elements
via CSS
Also, @hakre, I believe the SSL options are all handled by using
site_url() to generate URLs, but please correct me if I'm wrong.
Hopefully this is a step forward. Once people are happy with this, I'll
use some of the same ideas over on #10910 as well.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11172#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list