[wp-trac] [WordPress Trac] #11613: HTTP API may make a request on an unsupporting transport
WordPress Trac
wp-trac at lists.automattic.com
Fri Dec 25 22:48:12 UTC 2009
#11613: HTTP API may make a request on an unsupporting transport
--------------------------+-------------------------------------------------
Reporter: dd32 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: HTTP | Version: 2.9
Severity: normal | Keywords: needs-patch
--------------------------+-------------------------------------------------
Changes (by dd32):
* keywords: has-patch => needs-patch
Comment:
> won't the serialized args based key result in each transport being
tested on every call?
Just the calls which have varying args. The only non-arg in that list is
the post body, which can probably be nulled out, that way multiple post
requests will be able to use the cache again. It doesnt contain the URL,
so not a problem there.. But does differentiate between GET/POST/etc.
It is unavoidable that they get tested multiple times, It'd be much
simpler if the fallback to the next transport should the first fail worked
properly, #8622 that way, the arg could run ::test() itself when being
called, and if it wasnt up for the job, simply pass it onto the next best
transport.
Most pages will only have a small number of requests made, while it may
add another couple of ms to the function, in my opinion, the benifit of
the request actually suceeding and returning the correct data is worth
more.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11613#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list