[wp-trac] [WordPress Trac] #11504: PHP notices when publishing with QuickPress

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 25 09:14:23 UTC 2009


#11504: PHP notices when publishing with QuickPress
------------------------------+---------------------------------------------
 Reporter:  caesarsgrunt      |       Owner:  westi                  
     Type:  defect (bug)      |      Status:  accepted               
 Priority:  normal            |   Milestone:  3.0                    
Component:  Warnings/Notices  |     Version:  2.9                    
 Severity:  normal            |    Keywords:  has-patch needs-testing
------------------------------+---------------------------------------------

Comment(by nacin):

 hakre:

 I was using the patch when testing QuickPress for #10680. Looks good --
 two things:

 The line that sets $previous_status would now have two ternary operations,
 all for a function's second argument. It would probably be better as
 multiple lines.

 Also,
 {{{
 if ( 'page' == ( isset($_POST['post_type']) ? $_POST['post_type'] : null )
 )
 }}}
 Should probably be:
 {{{
 if ( isset($_POST['post_type']) && 'page' == $_POST['post_type'] )
 }}}

 That's all I got.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11504#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list