[wp-trac] [WordPress Trac] #11219: could not be converted to UTF-8 / WordPress should cache failed feed fetches so as to avoid overloading feed sources

[WordPress Trac]

#11219: could not be converted to UTF-8 / WordPress should cache failed feed
fetches so as to avoid overloading feed sources
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:                                    
     Type:  defect (bug)       |      Status:  new                               
 Priority:  high               |   Milestone:  2.9.1                             
Component:  Optimization       |     Version:  2.9                               
 Severity:  major              |    Keywords:  has-patch tested reporter-feedback
-------------------------------+--------------------------------------------
Changes (by westi):

  * keywords:  has-patch tested blocker => has-patch tested reporter-
               feedback


Comment:

 OK the 2.9 SimplePie has one change over the 2.8 one in the function
 {{{change_encoding}}}

 The test which starts {{{function_exists('mb_convert_encoding')}} has an
 extra check for
 {{{@mb_convert_encoding("\x80", 'UTF-16BE', $input) !== "\x00\x80"}}}

 So if 2.8 works on the server then is it likely this check that is failing
 now not that {{{function_exists('mb_convert_encoding')}}} fails?

 This check passes if {{{$input}}} is UTF-8 as 0x80 is an invalid UTF-8
 sequence - It has the top bit set and therefore is the second, third, or
 fourth byte of a multi-byte sequence.

 This check doesn't pass for ASCII as the {{{$input}}}.

 If you revert just this change does it work in 2.9?

 It looks like in 2.9 that part of {{{change_encoding}}} may only work if
 {{{$input}}} is UTF-8.

 I can't see how that function can work in 2.8 and not in 2.9 if neither
 iconv or mb_convert_encoding are present.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11219#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software