[wp-trac] [WordPress Trac] #9285: making sure post_date and post_date_gmt are correct

WordPress Trac wp-trac at lists.automattic.com
Wed Dec 23 11:13:25 UTC 2009


#9285: making sure post_date and post_date_gmt are correct
--------------------------+-------------------------------------------------
 Reporter:  hailin        |       Owner:  anonymous      
     Type:  defect (bug)  |      Status:  new            
 Priority:  normal        |   Milestone:  3.0            
Component:  Date/Time     |     Version:  2.8            
 Severity:  normal        |    Keywords:  has-patch early
--------------------------+-------------------------------------------------
Changes (by westi):

  * keywords:  has-patch tested commit early => has-patch early


Comment:

 I have one issue with the current patch.

 We have a window around the two non-DST > DST change over points where we
 will schedule the cron task for the wrong time with this change.

 For example if we are currently not in DST and have a post scheduled for
 5pm DST we will schedule for 4pm DST as the current offset would be 1 hour
 less than when in DST.

 This will be caught by {{{check_and_publish_future_post}}} and it will
 reschedule - but it has the old style calculation there based on
 {{{post_date_gmt}}} so it will schedule based on that which could still be
 wrong.

 Now if we are currently in DST and have a post scheduled for 5pm non-DST
 we will schedule for 6pm non-DST as the current offset would be 1 hour
 more than when not in DST.

 This means that a post will publish one hour late.

 I'm not sure how much of this we can resolve - do we have access to the
 DST info for our current timezone when using the PHP5 auto-dst code?

 Removing commit and tested until we have an updated tested patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9285#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list