[wp-trac] [WordPress Trac] #11477: Unable to Crop Images in RC1
WordPress Trac
wp-trac at lists.automattic.com
Fri Dec 18 01:32:09 UTC 2009
#11477: Unable to Crop Images in RC1
--------------------------+-------------------------------------------------
Reporter: miqrogroove | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Media | Version: 2.9
Severity: major | Keywords:
--------------------------+-------------------------------------------------
Comment(by nacin):
I'm going to try to run through most of these.
> Enter an Aspect ratio. The image selection changes but the Selection
fields are not updated.
Priority: I'd consider this important if only because one would generally
tab out of the aspect ratio box, which would immediately change the crop
to whatever was in the selection fields boxes.
To fix: setRatioSelection should also calculate and populate the selection
fields with the newest numbers.
> 4. Attempt to change the Aspect ratio to 4:7. Input is erased as soon as
I type it in. This makes no sense at first, but appears to be some kind of
boundary feedback?
Correct, this is boundary feedback. If the new aspect ratio would force
the crop boundaries to beyond the image, then it kicks back. Try a smaller
crop and then set a 4:7 and you'll have no problem. No bug here beyond
user feedback.
> 5. Attempt to change the Aspect ratio to 10:11. Input is impossible
unless the second field is empty.
Boundary feedback again. No bug.
> 6. Change the Aspect ratio to 7:8 and then change it to 7.9:8. Nothing
happens.
Given that two of the five common aspect ratios are decimals (1.85:1 and
2.39:1), it would make sense that the intvals are removed from
setRatioSelection.
To fix: Allow aspect ratios to be floats.
> 7. In common graphics vocabulary, "Selection" always refers to a pair of
rectangular coordinates. Using the word "Selection" where "Size" is what
you meant to say is confusing.
Where?
> 8. Scale Image is collapsed by default, with no indiciation that it can
be expanded except for a slight difference in text color, and the cursor
changes on mouse over.
I'd tend to agree. Fix: Hide help text with consistent (help) link,
otherwise always display scale section.
> 9. The interface would make more sense with a limited set of radio
options for aspect ratios.
I'd tend to agree, but nothing should be changed at this point.
> 10. The original image Aspect Ratio is not displayed. If my image has an
Aspect of 1.39847, and I want to "lock it in" while cropping, there is no
obvious way to do it.
> 11. The new image Aspect Ratio is not displayed. If I crop by click &
drag, or by typing in the Selection fields, there is no way to know the
resulting Aspect Ratio without pulling out a calculator.
As long as they remain fields versus radio buttons, the Aspect Ratio boxes
should probably be populated just as the selection fields are.
> 12. The original image dimensions are not displayed, unless the Scale
Image area has been expanded. Cropping is just that much more awkward as a
result.
See my suggestion above (#8).
> 13. The "Save" button is broken. It's always greyed out on my screen.
Why is it there? What does it do?
It saves the changes. Execute a crop then see it become enabled.
> 14. When holding down the Shift key, Click & Drag only works when the
cursor is moving from upper left to lower right. Weird behavior when
dragging toward the upper left corner.
Yea, that is weird.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11477#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list