[wp-trac] [WordPress Trac] #10555: number_format_i18n function doesn't check if the number is float or not before doing the formating

[WordPress Trac]

#10555: number_format_i18n function doesn't check if the number is float or not
before doing the formating
--------------------------+-------------------------------------------------
 Reporter:  chombium      |       Owner:  nbachiyski                   
     Type:  defect (bug)  |      Status:  new                          
 Priority:  normal        |   Milestone:  3.0                          
Component:  i18n          |     Version:  2.9                          
 Severity:  normal        |    Keywords:  has-patch needs-testing early
--------------------------+-------------------------------------------------

Comment(by chombium):

 The problem that I experienced was because there was no documentation that
 only integers are passed to this function and that there is no remark that
 the value for the decimals in the translation file should always be 0.

 Because the value is already in the translation file and if the function
 is patched, I think the best way to solve this issue is to add a remark in
 the translation file and to update the
 http://codex.wordpress.org/Translating_WordPress page, that for now, the
 msgid "number_format_decimals" should be set to 0.

 The comment:
 "#. translators: $decimals argument for http://php.net/number_format,
 default is 0"
 in the file http://svn.automattic.com/wordpress-
 i18n/pot/trunk/wordpress.pot should be updated with something like "set it
 to 0" as well

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10555#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software