[wp-trac] [WordPress Trac] #11456: excerpt_more tweak

[WordPress Trac]

#11456: excerpt_more tweak
--------------------------+-------------------------------------------------
 Reporter:  demetris      |        Owner:        
     Type:  defect (bug)  |       Status:  closed
 Priority:  high          |    Milestone:  2.9   
Component:  Formatting    |      Version:  2.9   
 Severity:  normal        |   Resolution:  fixed 
 Keywords:  has-patch     |  
--------------------------+-------------------------------------------------

Comment(by demetris):

 @hakre:

 LOL.  My concatenation is rather unpopular.  And I got rboren into trouble
 with it. :-D

 From the wp-dev channel:

 > (6:43:37 PM) filosofo: uh, why ' ' . '[...]' in r12414 ?

 > (6:44:01 PM) filosofo: how is that better than ' [...]'?

 > SNIP

 > (6:52:03 PM) rboren: filosofo: Thought about changing it but then
 thought it made the rather extraneous nature of the space more apparent.

 > (6:52:11 PM) rboren: Would like to just get rid of it though.

 > SNIP

 > (7:01:24 PM) demetris: rboren: filosofo: re r12414 -- My patch split the
 string into two for the reason rboren said.  To make it obvious where the
 space was added, and also as an indication to people hacking the code in
 the future, that this space is there on purpose; it is not a typo, for
 example. But I am not a coder myself, so I dont know if this is good
 practice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11456#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software