[wp-trac] [WordPress Trac] #11442: Untrashed comments could be deleted by wp_scheduled_delete()

WordPress Trac wp-trac at lists.automattic.com
Tue Dec 15 20:20:29 UTC 2009


#11442: Untrashed comments could be deleted by wp_scheduled_delete()
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  high          |   Milestone:  2.9      
Component:  Trash         |     Version:  2.9      
 Severity:  blocker       |    Keywords:  has-patch
--------------------------+-------------------------------------------------
Changes (by nacin):

  * severity:  blocker => blocker


Comment:

 Patch 4: I like it, and it looked like what I was considering but I
 haven't had time to re-patch.

 I'm trying to run it through my head for how trashed -> spammed (and vice
 versa) would work, but this appears to fix the blocker.

 Patch 5: I actually liked the simple wp_(action)_comment() functions as an
 API. They've also been around long enough in beta that removing them might
 be a compat issue. Combining them I suppose makes sense though.

 Do we add back all sorts of pre- and post- actions?

 Spam didn't previously have an expiration time; they just got wiped by
 wp_scheduled_delete() (at least how I understood it).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11442#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list