[wp-trac] [WordPress Trac] #11426: Allow trash option in comment notification emails

[WordPress Trac]

#11426: Allow trash option in comment notification emails
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  2.9      
Component:  Trash         |     Version:  2.9      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by nacin):

 Replying to [comment:11 caesarsgrunt]:
 > Regarding the names of the actions, I don't see any point in renaming
 them at all if the new names are still going to be different from the ones
 used in other places. There's nothing really ''wrong'' with {{{cdc}}} and
 {{{mac}}} - and if it's shortness you're going for, you can't beat them!
 (Unless you were to have like {{{t}}} for trash, {{{s}}} for spam, and
 {{{a}}} for approve... actually, there might be something to be said for
 that...)

 Here's my thought. It really isn't much to ask that the links should be
 short, readable, and distinguishable. All three options are short enough.
 However, I didn't have a clue what 'mac' or 'cdc' was until I looked back
 in the changesets when they were shortened 3 years ago. They're not
 understandable to an end user, but why shouldn't they be?

 The one-character strings could work, but they're not readable or easily
 distinguishable.

 The point of renaming them is simple. We're already creating two new
 actions, spam and trash, and getting rid of dt. So we might as well
 standardize 'approve' and 'delete' as well. They're only different because
 they perform a unique AYS function. And FWIW, adding "comment" to the
 action generates the post-AYS action, so this standardizes it and makes
 them alike, not different. And because of that, the code is easier, too.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11426#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software